MWPW-158053: CCD Slice Card [Merch card] #2878

Axelcureno · 2024-09-13T20:10:25Z

Introduces Creative Cloud Desktop 'Slice' Card to the list of web components as part of M@S v2 initiative.

LTR:

RTL:

Notes:

This card is not part of Milo block library and is part of a CCD integration.
To test this card, run npm run test from web-components folder and select debug, then select the option test/merch-card.ccd-slice.test.html to see the 2 options (standard size and wide)

Test URLs:

- move from merch-card.js code each layout code related to a given variant under variants/<variant> class - move from global.css.js css related to a given variant under variants/<variant>.css.js - move from merch-card.css.js wc css related to a given variant under variants/<variant>.variantStyle - uses variants/variants as an index to get related class from related variant, and wc style too, - uses variants/VariantLayout, superclass of all variants, to insert css if card is used, and hold common code

to something independent of the layout (not initialized when used at first in collections)

aem-code-sync · 2024-09-13T20:10:29Z

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

Re-run PSI checks
Re-sync branch

Commits

c3289a7 ✅ (latest)
1139b0f ✅
17a18a1 ✅
2b04688 ✅
3e9ed08 ✅
b174f0d ✅
f84c67c ✅
f30355d ✅
cdb6c8c ✅
8273f59 ✅
3a656a7 ✅
ae57a05 ✅
95698c4 ✅
afaf7ff ✅
ed4137a ✅
950c3ae ✅
49b3acd ✅
bc3ae26 ✅
9aa3eee ✅
5ad2935 ✅
6c3cb8f ✅
6df1623 ✅
b9580d5 ✅
a8ab869 ✅
7ead9eb ✅
03778dd ✅

aem-code-sync · 2024-09-13T20:10:53Z

	Page	Scores	Audits	Google
📱	/?martech=off
🖥️	/?martech=off

github-actions · 2024-09-13T20:11:01Z

libs/features/mas/web-components/src/variants/ccd-slice.css.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-13T20:11:02Z

libs/features/mas/web-components/src/variants/ccd-slice.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-13T20:11:03Z

libs/features/mas/web-components/src/variants/variants.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-13T20:11:04Z

libs/features/mas/web-components/test/merch-card.ccd-slice.test.html.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

codecov · 2024-09-13T20:12:00Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.29%. Comparing base (5ddeb73) to head (c3289a7).
Report is 4 commits behind head on stage.

Additional details and impacted files

@@           Coverage Diff            @@
##            stage    #2878    +/-   ##
========================================
  Coverage   96.29%   96.29%            
========================================
  Files         240      242     +2     
  Lines       54739    54850   +111     
========================================
+ Hits        52709    52818   +109     
- Misses       2030     2032     +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-16T16:57:08Z

libs/features/mas/web-components/src/merch-datasource.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-17T01:11:30Z

This pull request is not passing all required checks. Please see this discussion for information on how to get all checks passing. Inconsistent checks can be manually retried. If a test absolutely can not pass for a good reason, please add a comment with an explanation to the PR.

3ch023 · 2024-09-17T12:01:55Z

Hi @Axelcureno, just a suggestion, but if we wait for #2894 we can add a test page showcasing the CCD cards you've implemented

3ch023

we might not need the images for unit tests, as discussed before with Milo core team.
rest looks good to me.
p.s. for PSI check - we can create a test page with odin resources, once #2894 is ready

npeltier

thanks @Axelcureno, looks great :)

Roycethan · 2024-09-24T01:40:09Z

@Axelcureno Price element is not wrapped to previous line

Roycethan · 2024-09-24T01:45:40Z

@Axelcureno Price element is not wrapped to previous line

Fixed in b174f0d

Roycethan · 2024-09-24T02:33:59Z

@Axelcureno Can you plz fix the failure at https://github.com/adobecom/milo/pull/2878/checks?check_run_id=30558428790

npeltier · 2024-09-24T11:33:39Z

libs/features/mas/web-components/src/variants/ccd-slice.js

+  renderLayout() {
+    return html` <div class="content">
+          <slot name="icons"></slot> ${this.badge}
+          <slot name="body-s"></slot>


typo: this should be body-xs

or merch-datasource that should be body-s too :)

I have fixed in merch-datasource, thank you.

npeltier · 2024-09-24T11:51:58Z

please fix my last comment on description typo https://github.com/adobecom/milo/pull/2878/files#r1773166090

milo-pr-merge · 2024-09-24T16:12:46Z

Skipped 2878: "MWPW-158053: CCD Slice Card [Merch card]" due to file "libs/features/mas/web-components/src/merch-datasource.js" overlap. Merging will be attempted in the next batch

github-actions · 2024-09-24T16:54:21Z

libs/deps/mas/merch-card.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

github-actions · 2024-09-24T16:54:22Z

libs/deps/mas/merch-datasource.js

⚠️ [eslint] _{reported by reviewdog 🐶}
File ignored because of a matching ignore pattern. Use "--no-ignore" to override.

npeltier and others added 10 commits August 31, 2024 00:18

MWPW-156612 changing title selector

7ead9eb

to something independent of the layout (not initialized when used at first in collections)

MWPW-156612 forking style insertion

a8ab869

MWPW-156612 styles fixes

b9580d5

MWPW-156612 review comments

6df1623

Merge branch 'stage' of github.com:adobecom/milo into MWPW-156612

6c3cb8f

MWPW-156612 fixing unit tests

5ad2935

initial commit

9aa3eee

Merge branch 'stage' into MWPW-158053

bc3ae26

MWPW-158053: CCD Slide Card

49b3acd

Axelcureno added commerce needs-verification PR requires E2E testing by a reviewer merch card labels Sep 13, 2024

Axelcureno self-assigned this Sep 13, 2024

Axelcureno requested a review from a team as a code owner September 13, 2024 20:10

github-actions bot reviewed Sep 13, 2024

View reviewed changes

RTL alignment

950c3ae

aem-code-sync bot temporarily deployed to MWPW-158053 September 16, 2024 16:21 Inactive

ccd slice card added to merch-datasource libs

ed4137a

aem-code-sync bot temporarily deployed to MWPW-158053 September 16, 2024 16:56 Inactive

github-actions bot reviewed Sep 16, 2024

View reviewed changes

3ch023 approved these changes Sep 17, 2024

View reviewed changes

Axelcureno requested a review from narcis-radu September 19, 2024 18:28

Axelcureno added 2 commits September 19, 2024 13:58

Update merch-card.ccd-slice.test.html.js

f30355d

Update merch-twp-d2p.test.html

f84c67c

aem-code-sync bot temporarily deployed to MWPW-158053 September 19, 2024 21:02 Inactive

npeltier approved these changes Sep 20, 2024

View reviewed changes

npeltier approved these changes Sep 23, 2024

View reviewed changes

yesil approved these changes Sep 23, 2024

View reviewed changes

Update ccd-slice.js

b174f0d

Roycethan added verified PR has been E2E tested by a reviewer and removed needs-verification PR requires E2E testing by a reviewer labels Sep 24, 2024

Merge branch 'stage' into MWPW-158053

3e9ed08

aem-code-sync bot temporarily deployed to MWPW-158053 September 24, 2024 01:55 Inactive

npeltier reviewed Sep 24, 2024

View reviewed changes

Axelcureno added 2 commits September 24, 2024 06:55

Update merch-datasource.js

2b04688

Merge branch 'stage' into MWPW-158053

17a18a1

aem-code-sync bot temporarily deployed to MWPW-158053 September 24, 2024 14:03 Inactive

Roycethan added the Ready for Stage label Sep 24, 2024

Axelcureno added 2 commits September 24, 2024 09:47

inherited width of images

1139b0f

updated deps

c3289a7

aem-code-sync bot deployed to MWPW-158053 September 24, 2024 16:53 View deployment

github-actions bot reviewed Sep 24, 2024

View reviewed changes

milo-pr-merge bot merged commit e921f64 into stage Sep 25, 2024
14 checks passed

milo-pr-merge bot deleted the MWPW-158053 branch September 25, 2024 08:32

milo-pr-merge bot mentioned this pull request Sep 25, 2024

[Release] Stage to Main #2951

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MWPW-158053: CCD Slice Card [Merch card] #2878

MWPW-158053: CCD Slice Card [Merch card] #2878

Axelcureno commented Sep 13, 2024 •

edited

Loading

aem-code-sync bot commented Sep 13, 2024 •

edited

Loading

aem-code-sync bot commented Sep 13, 2024 •

edited

Loading

github-actions bot Sep 13, 2024

github-actions bot Sep 13, 2024

github-actions bot Sep 13, 2024

github-actions bot Sep 13, 2024

codecov bot commented Sep 13, 2024 •

edited

Loading

github-actions bot Sep 16, 2024

github-actions bot commented Sep 17, 2024

3ch023 commented Sep 17, 2024

3ch023 left a comment •

edited

Loading

npeltier left a comment

Roycethan commented Sep 24, 2024

Roycethan commented Sep 24, 2024

Roycethan commented Sep 24, 2024

npeltier Sep 24, 2024

npeltier Sep 24, 2024

Axelcureno Sep 24, 2024

npeltier commented Sep 24, 2024

milo-pr-merge bot commented Sep 24, 2024

github-actions bot Sep 24, 2024

github-actions bot Sep 24, 2024

MWPW-158053: CCD Slice Card [Merch card] #2878

MWPW-158053: CCD Slice Card [Merch card] #2878

Conversation

Axelcureno commented Sep 13, 2024 • edited Loading

aem-code-sync bot commented Sep 13, 2024 • edited Loading

aem-code-sync bot commented Sep 13, 2024 • edited Loading

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

github-actions bot Sep 13, 2024

Choose a reason for hiding this comment

codecov bot commented Sep 13, 2024 • edited Loading

Codecov Report

github-actions bot Sep 16, 2024

Choose a reason for hiding this comment

github-actions bot commented Sep 17, 2024

3ch023 commented Sep 17, 2024

3ch023 left a comment • edited Loading

Choose a reason for hiding this comment

npeltier left a comment

Choose a reason for hiding this comment

Roycethan commented Sep 24, 2024

Roycethan commented Sep 24, 2024

Roycethan commented Sep 24, 2024

npeltier Sep 24, 2024

Choose a reason for hiding this comment

npeltier Sep 24, 2024

Choose a reason for hiding this comment

Axelcureno Sep 24, 2024

Choose a reason for hiding this comment

npeltier commented Sep 24, 2024

milo-pr-merge bot commented Sep 24, 2024

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

github-actions bot Sep 24, 2024

Choose a reason for hiding this comment

Axelcureno commented Sep 13, 2024 •

edited

Loading

aem-code-sync bot commented Sep 13, 2024 •

edited

Loading

aem-code-sync bot commented Sep 13, 2024 •

edited

Loading

codecov bot commented Sep 13, 2024 •

edited

Loading

3ch023 left a comment •

edited

Loading